From 74e48aa1e59ec4f23d18f82b9489194c3e2f544d Mon Sep 17 00:00:00 2001 From: sysadmin Date: Wed, 10 Jun 2026 23:26:08 +0100 Subject: [PATCH] fix(build): drop invalid --no-incremental from dotnet publish (MSB1001) dotnet publish rejects --no-incremental (it's a dotnet build switch) -> MSB1001 Unknown switch -> build failed. The bin/obj wipe alone forces the clean recompile we need. Co-Authored-By: Claude Opus 4.8 --- windows/installer/build.ps1 | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/windows/installer/build.ps1 b/windows/installer/build.ps1 index 4b5a707..ec07486 100644 --- a/windows/installer/build.ps1 +++ b/windows/installer/build.ps1 @@ -162,10 +162,11 @@ function Invoke-PublishWelcome { $out = Join-Path $WorkDir 'welcome-publish' # Force a CLEAN compile. The CI runner reuses build artifacts across runs, and dotnet's # incremental build has shipped a STALE SilverOS.Welcome.Core.dll (old code despite fixed - # source) -- so wipe every bin/obj under welcome/ and pass --no-incremental. + # source) -- so wipe every bin/obj under welcome/ before publishing (a clean tree forces a + # full recompile; note `dotnet publish` does NOT accept --no-incremental). Get-ChildItem (Join-Path $WindowsDir 'welcome') -Recurse -Directory -EA SilentlyContinue | Where-Object { $_.Name -in 'bin', 'obj' } | Remove-Item -Recurse -Force -EA SilentlyContinue - & dotnet publish $proj -c Release -f net9.0-windows10.0.19041.0 -r win-x64 --self-contained true --no-incremental -o $out + & dotnet publish $proj -c Release -f net9.0-windows10.0.19041.0 -r win-x64 --self-contained true -o $out if ($LASTEXITCODE -ne 0) { throw 'Welcome app dotnet publish failed' } Write-Host " Published to: $out" }