SilverLABS/SilverMetal
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(build): clean compile before publish (CI shipped a stale toolbox DLL) #32

Merged
SilverLABS merged 1 commits from fix/ci-clean-publish into main 2026-06-10 22:21:30 +00:00
Conversation 0 Commits 1 Files Changed 1 +6 -1
SilverLABS commented 2026-06-10 22:21:19 +00:00
Owner
Copy Link

The meta-bug behind the last several "fix didn't work" runs

Disk forensics on the #116 VM: the deployed SilverOS.Welcome.Core.dll was timestamped 19:14 — before build #116 even ran (~21:46). So the CI runner's incremental build reused a cached Core.dll, and the published toolbox shipped old code despite the source being fixed. That's why the winget-bootstrap brace fix (correct on main) still showed the old }} parse error in appinstall.log, and likely why earlier toolbox fixes appeared not to take.

Fix

In Invoke-PublishWelcome: wipe every bin/obj under windows/welcome/ and pass --no-incremental, so each ISO build does a clean compile of the toolbox.

Test Plan

  • build.ps1 parses
  • Next build's Core.dll is newer than the build start; appinstall.log shows the new bootstrap path (-File), winget resolves, apps install

🤖 Generated with Claude Code

## The meta-bug behind the last several "fix didn't work" runs Disk forensics on the #116 VM: the deployed `SilverOS.Welcome.Core.dll` was timestamped **19:14** — *before* build #116 even ran (~21:46). So the CI runner's **incremental build reused a cached `Core.dll`**, and the published toolbox shipped **old code despite the source being fixed**. That's why the winget-bootstrap brace fix (correct on `main`) still showed the old `}}` parse error in `appinstall.log`, and likely why earlier toolbox fixes appeared not to take. ## Fix In `Invoke-PublishWelcome`: wipe every `bin`/`obj` under `windows/welcome/` and pass `--no-incremental`, so each ISO build does a clean compile of the toolbox. ## Test Plan - [x] `build.ps1` parses - [ ] Next build's `Core.dll` is newer than the build start; `appinstall.log` shows the **new** bootstrap path (`-File`), winget resolves, apps install 🤖 Generated with [Claude Code](https://claude.com/claude-code)
SilverLABS added 1 commit 2026-06-10 22:21:19 +00:00
fix(build): clean compile before publish (CI shipped stale Core.dll)
Some checks failed
Build SilverMetal Enhanced - Windows ISO / build (pull_request) Failing after 1m31s
Details
9832121dbb 
The deployed toolbox Core.dll was timestamped BEFORE its own build ran -- the CI runner's
incremental build reused a cached SilverOS.Welcome.Core.dll, so source fixes (e.g. the winget
bootstrap brace fix) never reached the published exe. Wipe all bin/obj under welcome/ and pass
--no-incremental so every build is a clean compile.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SilverLABS merged commit a6ac6ce355 into main 2026-06-10 22:21:30 +00:00
SilverLABS deleted branch fix/ci-clean-publish 2026-06-10 22:21:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
SilverLABS
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SilverLABS/SilverMetal#32
Delete Branch "fix/ci-clean-publish"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?