SilverLABS/SilverMetal
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(kiosk): WESL DefaultAction is sint32 not uint32 (2nd e2e finding) #8

Merged
SilverLABS merged 1 commits from fix/kiosk-defaultaction-type into main 2026-06-09 15:46:29 +00:00
Conversation 0 Commits 1 Files Changed 1 +2 -2
SilverLABS commented 2026-06-09 15:41:04 +00:00
Owner
Copy Link

Follow-up to #7, found in the 2nd VM e2e. With the class-level calls from #7, Shell Launcher config got one step further but still failed:

SHELL LAUNCHER CONFIG FAILED: Type mismatch for parameter "DefaultAction"

WESL_UserSetting.SetCustomShell / SetDefaultShell take sint32 (Int32) DefaultAction, but we passed [uint32]0. The #7 fail-open rollback worked correctly (no brick — booted to a normal Explorer session) but the kiosk never engaged and the wizard didn't run.

Fix: pass [int32]0.

Verified: Configure-Kiosk.ps1 parses. Diff is exactly the two DefaultAction casts. Next: rebuild → restage → 3rd VM run to confirm the kiosk shell engages on the sm-bootstrap autologon (the one remaining unknown — whether Shell Launcher takes over same-boot).

🤖 Generated with Claude Code

Follow-up to #7, found in the **2nd VM e2e**. With the class-level calls from #7, Shell Launcher config got one step further but still failed: ``` SHELL LAUNCHER CONFIG FAILED: Type mismatch for parameter "DefaultAction" ``` `WESL_UserSetting.SetCustomShell` / `SetDefaultShell` take **`sint32`** (Int32) `DefaultAction`, but we passed `[uint32]0`. The #7 fail-open rollback worked correctly (no brick — booted to a normal Explorer session) but the kiosk never engaged and the wizard didn't run. **Fix:** pass `[int32]0`. Verified: `Configure-Kiosk.ps1` parses. Diff is exactly the two `DefaultAction` casts. Next: rebuild → restage → 3rd VM run to confirm the kiosk shell engages on the `sm-bootstrap` autologon (the one remaining unknown — whether Shell Launcher takes over same-boot). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
SilverLABS added 1 commit 2026-06-09 15:41:04 +00:00
fix(kiosk): WESL DefaultAction is sint32, not uint32 (config failed -> fail-open, no kiosk)
All checks were successful
Build SilverMetal Enhanced - Windows ISO / build (pull_request) Successful in 4m39s
Details
cc6369e3b3 
2nd VM e2e: Shell Launcher config still failed with 'Type mismatch for parameter
DefaultAction'. WESL_UserSetting.SetCustomShell/SetDefaultShell take sint32 (Int32)
DefaultAction, but we passed [uint32]0. The fail-open rollback worked (no brick,
booted to Explorer) but the kiosk never engaged. Pass [int32]0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
SilverLABS merged commit 09216d6cfb into main 2026-06-09 15:46:29 +00:00
SilverLABS deleted branch fix/kiosk-defaultaction-type 2026-06-09 15:46:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
SilverLABS
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SilverLABS/SilverMetal#8
Delete Branch "fix/kiosk-defaultaction-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?