SilverLABS/littleshop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix BTCPay Server integration for production deployment

Browse Source 
- Fixed invoice creation to use GBP (fiat) instead of cryptocurrency amounts
- BTCPay Server now handles automatic crypto conversion
- Updated payment flow to use checkout links instead of raw wallet addresses
- Added comprehensive logging for debugging payment issues
- Created diagnostic endpoints for testing BTCPay connection and payments
- Added documentation for deployment and troubleshooting

The key issue was that BTCPay v2 manages wallet addresses internally and provides checkout links for customers to complete payments, rather than exposing raw crypto addresses.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
SilverLabs DevTeam
2025-09-19 10:21:04 +01:00
parent 54618348ab
commit 6f0efa6252
4 changed files with 329 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
LittleShop/Services/BTCPayServerService.cs
View File

@@ -16,35 +16,41 @@ public class BTCPayServerService : IBTCPayServerService
{
private readonly BTCPayServerClient _client;
private readonly IConfiguration _configuration;
private readonly ILogger<BTCPayServerService> _logger;
private readonly string _storeId;
private readonly string _webhookSecret;
private readonly string _baseUrl;
public BTCPayServerService(IConfiguration configuration)
public BTCPayServerService(IConfiguration configuration, ILogger<BTCPayServerService> logger)
{
_configuration = configuration;
var baseUrl = _configuration["BTCPayServer:BaseUrl"] ?? throw new ArgumentException("BTCPayServer:BaseUrl not configured");
_logger = logger;
_baseUrl = _configuration["BTCPayServer:BaseUrl"] ?? throw new ArgumentException("BTCPayServer:BaseUrl not configured");
var apiKey = _configuration["BTCPayServer:ApiKey"] ?? throw new ArgumentException("BTCPayServer:ApiKey not configured");
_storeId = _configuration["BTCPayServer:StoreId"] ?? throw new ArgumentException("BTCPayServer:StoreId not configured");
_webhookSecret = _configuration["BTCPayServer:WebhookSecret"] ?? throw new ArgumentException("BTCPayServer:WebhookSecret not configured");
_webhookSecret = _configuration["BTCPayServer:WebhookSecret"] ?? "";
_logger.LogInformation("Initializing BTCPay Server connection to {BaseUrl} with Store ID: {StoreId}", _baseUrl, _storeId);
// Create HttpClient with certificate bypass for internal networks
var httpClient = new HttpClient(new HttpClientHandler()
{
ServerCertificateCustomValidationCallback = (message, cert, chain, errors) => true
});
_client = new BTCPayServerClient(new Uri(baseUrl), apiKey, httpClient);
_client = new BTCPayServerClient(new Uri(_baseUrl), apiKey, httpClient);
}
public async Task<string> CreateInvoiceAsync(decimal amount, CryptoCurrency currency, string orderId, string? description = null)
{
var currencyCode = GetCurrencyCode(currency);
var paymentMethod = GetPaymentMethod(currency);
var metadata = new JObject
{
["orderId"] = orderId,
["currency"] = currencyCode
["requestedCurrency"] = currency.ToString(),
["paymentMethod"] = paymentMethod
};
if (!string.IsNullOrEmpty(description))
@@ -52,37 +58,39 @@ public class BTCPayServerService : IBTCPayServerService
metadata["itemDesc"] = description;
}
// Create invoice in GBP (fiat) - BTCPay will handle crypto conversion
var request = new CreateInvoiceRequest
{
Amount = amount,
Currency = currencyCode,
Currency = "GBP", // Always use fiat currency for the amount
Metadata = metadata,
Checkout = new CreateInvoiceRequest.CheckoutOptions
{
Expiration = TimeSpan.FromHours(24)
Expiration = TimeSpan.FromHours(24),
PaymentMethods = new[] { paymentMethod }, // Specify which crypto to accept
DefaultPaymentMethod = paymentMethod
}
};
try
{
_logger.LogDebug("Creating BTCPay invoice - Amount: {Amount} GBP, Payment Method: {PaymentMethod}, Order: {OrderId}",
amount, paymentMethod, orderId);
var invoice = await _client.CreateInvoice(_storeId, request);
_logger.LogInformation("✅ Created BTCPay invoice {InvoiceId} for Order {OrderId} - Amount: {Amount} GBP, Method: {PaymentMethod}, Checkout: {CheckoutLink}",
invoice.Id, orderId, amount, paymentMethod, invoice.CheckoutLink);
return invoice.Id;
}
catch (Exception ex)
{
// Log the specific error for debugging
Console.WriteLine($"BTCPay Server error for {currencyCode}: {ex.Message}");
// Try to continue with real API call for all cryptocurrencies with configured wallets
if (currency == CryptoCurrency.BTC || currency == CryptoCurrency.LTC || currency == CryptoCurrency.DASH || currency == CryptoCurrency.XMR)
{
throw; // Let the calling service handle errors for supported currencies
}
// For XMR and ETH, we have nodes but BTCPay Server might not be configured yet
// Log the error and fall back to placeholder for now
Console.WriteLine($"Falling back to placeholder for {currencyCode} - BTCPay Server integration pending");
return $"invoice_{Guid.NewGuid()}";
_logger.LogError(ex, "❌ Failed to create BTCPay invoice - Amount: {Amount} GBP, Method: {PaymentMethod}, Store: {StoreId}, BaseUrl: {BaseUrl}",
amount, paymentMethod, _storeId, _baseUrl);
// Always throw - never generate fake invoices
throw;
}
}

72
LittleShop/Services/CryptoPaymentService.cs
View File

@@ -13,15 +13,18 @@ public class CryptoPaymentService : ICryptoPaymentService
private readonly LittleShopContext _context;
private readonly IBTCPayServerService _btcPayService;
private readonly ILogger<CryptoPaymentService> _logger;
private readonly IConfiguration _configuration;
public CryptoPaymentService(
LittleShopContext context,
LittleShopContext context,
IBTCPayServerService btcPayService,
ILogger<CryptoPaymentService> logger)
ILogger<CryptoPaymentService> logger,
IConfiguration configuration)
{
_context = context;
_btcPayService = btcPayService;
_logger = logger;
_configuration = configuration;
}
public async Task<CryptoPaymentDto> CreatePaymentAsync(Guid orderId, CryptoCurrency currency)
@@ -45,15 +48,46 @@ public class CryptoPaymentService : ICryptoPaymentService
// Create BTCPay Server invoice
var invoiceId = await _btcPayService.CreateInvoiceAsync(
order.TotalAmount,
currency,
order.TotalAmount,
currency,
order.Id.ToString(),
$"Order #{order.Id} - {order.Items.Count} items"
);
// For now, generate a placeholder wallet address
// In a real implementation, this would come from BTCPay Server
var walletAddress = GenerateWalletAddress(currency);
// Get the real wallet address from BTCPay Server
var invoice = await _btcPayService.GetInvoiceAsync(invoiceId);
if (invoice == null)
{
throw new InvalidOperationException($"Failed to retrieve invoice {invoiceId} from BTCPay Server");
}
// Extract the wallet address from the invoice
string walletAddress;
decimal cryptoAmount = 0;
try
{
// BTCPay Server v2 uses CheckoutLink for payment
// The actual wallet addresses are managed internally by BTCPay
// Customers should use the CheckoutLink to make payments
walletAddress = invoice.CheckoutLink ?? $"https://{_configuration["BTCPayServer:BaseUrl"]}/i/{invoiceId}";
// For display purposes, we can show the checkout link
// BTCPay handles all the wallet address generation internally
_logger.LogInformation("Created payment for {Currency} - Invoice: {InvoiceId}, Checkout: {CheckoutLink}",
currency, invoiceId, walletAddress);
// Set the amount from the invoice (will be in fiat)
cryptoAmount = invoice.Amount > 0 ? invoice.Amount : order.TotalAmount;
}
catch (Exception ex)
{
_logger.LogError(ex, "Error processing invoice {InvoiceId}", invoiceId);
// Fallback to a generated checkout link
walletAddress = $"https://{_configuration["BTCPayServer:BaseUrl"]}/i/{invoiceId}";
cryptoAmount = order.TotalAmount;
}
var cryptoPayment = new CryptoPayment
{
@@ -61,7 +95,7 @@ public class CryptoPaymentService : ICryptoPaymentService
OrderId = orderId,
Currency = currency,
WalletAddress = walletAddress,
RequiredAmount = order.TotalAmount, // This should be converted to crypto amount
RequiredAmount = cryptoAmount > 0 ? cryptoAmount : order.TotalAmount, // Use crypto amount if available
PaidAmount = 0,
Status = PaymentStatus.Pending,
BTCPayInvoiceId = invoiceId, // This is the actual BTCPay invoice ID
@@ -160,21 +194,19 @@ public class CryptoPaymentService : ICryptoPaymentService
};
}
private static string GenerateWalletAddress(CryptoCurrency currency)
private static string GetPaymentMethodId(CryptoCurrency currency)
{
// Placeholder wallet addresses - in production these would come from BTCPay Server
var guid = Guid.NewGuid().ToString("N"); // 32 characters
return currency switch
{
CryptoCurrency.BTC => "bc1q" + guid[..26],
CryptoCurrency.XMR => "4" + guid + guid[..32], // XMR needs ~95 chars, use double GUID
CryptoCurrency.USDT => "0x" + guid[..32], // ERC-20 address
CryptoCurrency.LTC => "ltc1q" + guid[..26],
CryptoCurrency.ETH => "0x" + guid[..32],
CryptoCurrency.ZEC => "zs1" + guid + guid[..29], // Shielded address
CryptoCurrency.DASH => "X" + guid[..30],
CryptoCurrency.DOGE => "D" + guid[..30],
_ => "placeholder_" + guid[..20]
CryptoCurrency.BTC => "BTC",
CryptoCurrency.XMR => "XMR",
CryptoCurrency.USDT => "USDT",
CryptoCurrency.LTC => "LTC",
CryptoCurrency.ETH => "ETH",
CryptoCurrency.ZEC => "ZEC",
CryptoCurrency.DASH => "DASH",
CryptoCurrency.DOGE => "DOGE",
_ => "BTC"
};
}
}