From 77d29e14c1d0272949e4a0c872c8021609c2ea7b Mon Sep 17 00:00:00 2001
From: SysAdmin <sysadmin@silverlabs.uk>
Date: Wed, 8 Oct 2025 16:26:48 +0100
Subject: [PATCH] Fix: Text import variant parsing now correctly handles value,
 price, and stock
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fixed variant parsing to accept 3 fields: value, price override, stock quantity
- Removed invalid VariantTypes navigation property reference
- Auto-detect variant type (Weight for grams, Quantity for units)
- Format: - VariantValue; PriceOverride; StockQuantity

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 LittleShop/Services/ProductImportService.cs | 28 ++++++++++++---------
 products_import_ready.txt                   | 10 ++++----
 2 files changed, 21 insertions(+), 17 deletions(-)

diff --git a/LittleShop/Services/ProductImportService.cs b/LittleShop/Services/ProductImportService.cs
index ed8994c..447f19d 100644
--- a/LittleShop/Services/ProductImportService.cs
+++ b/LittleShop/Services/ProductImportService.cs
@@ -605,7 +605,7 @@ public class ProductImportService : IProductImportService
         var variantLines = lines.Where(l => l.TrimStart().StartsWith("-")).ToList();
         for (int i = 0; i < variantLines.Count; i++)
         {
-            await ParseAndImportVariantLine(product.Id, variantLines[i], i);
+            await ParseAndImportVariantLine(product.Id, variantLines[i], i, variantCollectionId);
         }
 
         // Parse and import multi-buys (lines starting with +)
@@ -656,27 +656,31 @@ public class ProductImportService : IProductImportService
         return properties;
     }
 
-    private async Task ParseAndImportVariantLine(Guid productId, string line, int sortOrder)
+    private async Task ParseAndImportVariantLine(Guid productId, string line, int sortOrder, Guid? variantCollectionId)
     {
-        // Format: - VariantName; Price; OptionalStockLevel
-        // Example: - Small; 8.00; 50
+        // Format: - VariantValue; PriceOverride; StockQuantity
+        // Example: - 10; 30.00; 100 (for "10 tablets at £30.00 with 100 in stock")
         var content = line.TrimStart('-').Trim();
         var parts = content.Split(';').Select(p => p.Trim()).ToArray();
 
-        if (parts.Length < 2) return; // Need at least name and price
+        if (parts.Length < 3) return; // Need variant value, price, and stock
 
-        var variantName = parts[0];
-        var price = ParseDecimal(parts[1], "variant price");
-        var stockLevel = parts.Length > 2 ? ParseInt(parts[2], "variant stock") : 0;
+        var variantValue = parts[0]; // The value (e.g., "10", "25", "3.5g", "28g")
+        var priceOverride = ParseDecimal(parts[1], "variant price");
+        var stockQuantity = ParseInt(parts[2], "variant stock");
+
+        // Determine variant type based on the value format
+        // If it contains 'g' (grams), use "Weight", otherwise use "Quantity"
+        string variantType = variantValue.ToLower().Contains("g") ? "Weight" : "Quantity";
 
         var variantDto = new CreateProductVariantDto
         {
             ProductId = productId,
-            Name = variantName,
-            Price = price,
-            StockLevel = stockLevel,
+            Name = variantValue,
+            Price = priceOverride,
+            StockLevel = stockQuantity,
             SortOrder = sortOrder,
-            VariantType = "Standard"
+            VariantType = variantType
         };
 
         await _productService.CreateProductVariantAsync(variantDto);
diff --git a/products_import_ready.txt b/products_import_ready.txt
index 9f0862e..016fdbf 100644
--- a/products_import_ready.txt
+++ b/products_import_ready.txt
@@ -79,7 +79,7 @@ Dutch import
 category: Vitamins
 price: 30.00
 weight: 10
-unit: Single
+unit: Unit
 stock: 100
 
 - 10; 30.00; 100
@@ -94,7 +94,7 @@ stock: 100
 category: Vitamins
 price: 40.00
 weight: 10
-unit: Single
+unit: Unit
 stock: 100
 
 - 10; 40.00; 100
@@ -105,7 +105,7 @@ stock: 100
 category: Vitamins
 price: 30.00
 weight: 10
-unit: Single
+unit: Unit
 stock: 100
 
 - 10; 30.00; 100
@@ -147,7 +147,7 @@ stock: 100
 category: Vitamins
 price: 50.00
 weight: 10
-unit: Single
+unit: Unit
 stock: 100
 
 - 10; 50.00; 100
@@ -159,7 +159,7 @@ stock: 100
 category: Herbal
 price: 60.00
 weight: 10
-unit: Single
+unit: Unit
 stock: 100
 
 - 10; 60.00; 100